Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Select): can not switch Value when data type is SelectedItem on Virtual mode #4850

Merged
merged 6 commits into from
Dec 14, 2024
Merged

fix(Select): can not switch Value when data type is SelectedItem on Virtual mode #4850

merged 6 commits into from
Dec 14, 2024

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 14, 2024 •
edited by sourcery-ai bot
Loading

can not switch Value when data type is SelectedItem on Virtual mode

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号

Description

fixes #4849

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix the issue where the Select component could not switch values when the data type is SelectedItem in Virtual mode.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Dec 14, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This PR fixes an issue with the Select component where values couldn't be switched properly in Virtual mode when using SelectedItem data type. The implementation modifies the value selection logic to correctly handle virtualized items and improves the way selected items are retrieved and created.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refactored the virtualized item retrieval logic
  • Modified GetVirtualizeItem to accept a value parameter for item lookup
  • Added logic to search for items in _result.Items collection
  • Removed dependency on OnQueryAsync check
  • Changed fallback behavior to create new SelectedItem with provided value
 src/BootstrapBlazor/Components/Select/Select.razor.cs
Updated item selection logic in TryParseSelectItem method
  • Changed source collection from Items to Rows for finding selected item
  • Updated GetVirtualizeItem call to pass the value parameter
 src/BootstrapBlazor/Components/Select/Select.razor.cs
Modified SelectedRow property implementation
  • Updated GetVirtualizeItem call to include CurrentValueAsString parameter
 src/BootstrapBlazor/Components/Select/Select.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4849 Fix the issue where Select component with SelectedItem data type cannot switch options correctly in versions 9.1.1/9.1.2 compared to 9.1.0 when virtual mode is enabled ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Dec 14, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 14, 2024
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Dec 14, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add XML documentation for the 'value' parameter in GetVirtualizeItem method
  • Ensure thorough testing of the selection behavior in Virtual mode, particularly with different data types and edge cases
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c673833) to head (4048d6b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #4850   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          623       623           
  Lines        27807     27809    +2     
  Branches      3980      3980           
=========================================
+ Hits         27807     27809    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 8b246b8 into main Dec 14, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-select branch December 14, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@ArgoZhang ArgoZhang

Labels
bug Something isn't working
Projects
None yet
Milestone
v9.0.0
Development

Successfully merging this pull request may close these issues.

bug(Select): 开启虚拟数据类型 SelectedItem 无法切换问题
1 participant
@ArgoZhang